HomePhabricator
Diffusion Comm d7722d01d6c5

[lib] Allow admins to react and edit messages in sidebars

Description

[lib] Allow admins to react and edit messages in sidebars

Summary:
This resolves ENG-9053.

In D13061, I accidentally limited these permissions to top-level (non-sidebar) descendants, instead of granting them for all descendants.

We only need to use TOP_LEVEL_DESCENDANT in cases where we want to restrict the permission for sidebars… for instance, we don't want sidebars to have children, so we use TOP_LEVEL_DESCENDANT for sidebar and subchannel creation permissions.

Test Plan:

  1. I set up a repro of the issue in my local environment
  2. I applied this diff to fix the issue
  3. I reset db_version to 67 to trigger migration 68 again
  4. After migration 68 ran again, I confirmed that the issue was gone

Reviewers: tomek, inka

Reviewed By: tomek

Differential Revision: https://phab.comm.dev/D13112

Details

Provenance
ashoatAuthored on Aug 19 2024, 8:04 AM
Reviewer
tomek
Differential Revision
D13112: [lib] Allow admins to react and edit messages in sidebars
Parents
rCOMM4e7545461387: Fix broken E2E notifications when Safari is closed
Branches
Unknown
Tags
Unknown