HomePhabricator
Diffusion Comm da5391ff5719

Implement isStaffRelease method in PlatformSpecificTools

Description

Implement isStaffRelease method in PlatformSpecificTools

Summary:
This differential introduces isStaffRelease in PlatformSpecificTools class. Method is callable from C++, Java and Objective-C code including NSE code. Ther reason for this functionality is that currently only JavaScript code can be landed
directly to the master and switched on only for staff users (using native/staff-utils.js). If developer wants to introduce some changes in native languages that sholud be active only for staff users they have to directly colaborate with release-maker.
With changes introduced in this diff developer can land staff-only changes directly to master by hiding them behind PlatformSpecificTools#isStaffRelease and release-maker only has to change two methods to return true inseated of false.

Test Plan:

  1. Apply this diff: https://gist.github.com/marcinwasowicz/38435924b5850515649253a2e490572e (CommCoreModule, CommNotificationsHandler, NSE)
  2. Build iOS and Android app.
  3. Log in on both - observe logs from CommCoreModule.
  4. Send notification to both: Observe logs from CommNotificationHandler and NSE (this one requires usage of console app)

Reviewers: atul, kamil, bartek, ashoat, jon

Reviewed By: atul, bartek, ashoat, jon

Subscribers: jon, ashoat, tomek

Differential Revision: https://phab.comm.dev/D8803

Details

Provenance
marcinAuthored on Aug 14 2023, 2:53 AM
Reviewer
atul
Differential Revision
D8803: Implement isStaffRelease method in PlatformSpecificTools
Parents
rCOMMafe1c380344f: Significant refactor of notification encryption code
Branches
Unknown
Tags
Unknown