HomePhabricator
Diffusion Comm de3563ffd621

[lib] Properly handle hashing in progress

Description

[lib] Properly handle hashing in progress

Summary:
When the hashing is in progress, we tell the server that our store hashes are correct. We were concluding that the hashing is in progress by checking if a hash value is null - which was incorrect because it can be null when an entry is missing. The solution was to introduce a function that tells if we can perform a state sync. This function returns false when thread store hashing is in progress and when we perform user state sync with non-authoritative keyservers.

https://linear.app/comm/issue/ENG-7990/state-sync-sometimes-doesnt-fix-the-state

Test Plan:
Check if state sync fixes a state with missing thread info.
Also checked if state sync updates a user name, current user name, and entry text.

Reviewers: inka, ashoat

Reviewed By: inka, ashoat

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D11800

Details

Provenance
tomekAuthored on Apr 25 2024, 8:05 AM
Reviewer
inka
Differential Revision
D11800: [lib] Properly handle hashing in progress
Parents
rCOMM4ba9c88fe604: [native] introduce TagFarcasterChannelParams
Branches
Unknown
Tags
Unknown