HomePhabricator
Diffusion Comm de6a3fd1d383

Handle key permanently invalidated error to fix Android app crash

Description

Handle key permanently invalidated error to fix Android app crash

Summary:
This differential fixes https://linear.app/comm/issue/ENG-7696/commsecurestore-crash-during-commmmkvinitialize. It is achieved by patching expo-secure-store according
to changes that expo team introduced in later version of this package:
https://github.com/expo/expo/pull/22716/commits/b94904a241711586a127e357283cca3192860efd#diff-779492a2d4624bb5a02d84e6ece255cde8f7178fc075eb1cc18b01e21eb8dc1a

Test Plan:

  1. Reproduce the crash by uninstalling and redeploying Android app from Android studio. It seems that the best device to reproduce in Pixel device or emulator running Android 14.
  2. Introduce this diff and see that the crash disappears.

Reviewers: ashoat, tomek, bartek

Reviewed By: ashoat, bartek

Differential Revision: https://phab.comm.dev/D11661

Details

Provenance
marcinAuthored on Apr 14 2024, 4:02 AM
Reviewer
ashoat
Differential Revision
D11661: Handle key permanently invalidated error to fix Android app crash
Parents
rCOMMa8ad5e68ca0f: [protos][identity] Add RPC for fetching multiple device lists
Branches
Unknown
Tags
Unknown