HomePhabricator
Diffusion Comm e43acc88c5c1

[web] [fix] regression: chat tabs disabled lost its bottom border when changing…

Tags
None
Referenced Files
F17184: Image 2022-03-01 at 6.00.21 PM.jpg
Mar 2 2022, 4:41 AM
F17182: Image 2022-03-01 at 5.54.40 PM.jpg
Mar 2 2022, 4:41 AM
Subscribers
None

Description

[web] [fix] regression: chat tabs disabled lost its bottom border when changing global border color.

Summary:

Image 2022-03-01 at 5.54.40 PM.jpg (1×1 px, 99 KB)
disabled state should match figma

Currently master looks like this:

Image 2022-03-01 at 6.00.21 PM.jpg (698×1 px, 68 KB)

Regression was added here: https://github.com/CommE2E/comm/commit/b64048cb2096a5c96c52212a16f0f125f581b31e

Test Plan: check figma: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/?node-id=1170%3A77104 that the design looks correct. Toggle background and focused

Reviewers: atul, palys-swm

Reviewed By: palys-swm

Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga

Differential Revision: https://phabricator.ashoat.com/D3317