HomePhabricator
Diffusion Comm e48d27779c09

[Flow202][lib][skip-ci] [15/23] Fix Flow issues in lib/reducers

Description

[Flow202][lib][skip-ci] [15/23] Fix Flow issues in lib/reducers

Summary:
In these cases Flow seems to fear that something might change the value of the secondary condition after it's checked. The errors are cleared after moving the secondary condition into its own branch (in two cases) and assigning the intermediate value before checking it (in one case).

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9706

Test Plan: Confirm the Flow errors go away

Reviewers: atul

Reviewed By: atul

Subscribers: tomek, wyilio

Differential Revision: https://phab.comm.dev/D9707

Details