HomePhabricator
Diffusion Comm e54b3a74315b

[web] Show a popup when client_version_unsupported

Tags
None
Referenced Files
F1549422: image.png
Apr 16 2024, 5:18 AM
File Not Attached
F1548893: image.png
Apr 16 2024, 5:18 AM
File Not Attached
F1524374: Screenshot 2024-04-11 at 16.47.54.png
Apr 16 2024, 5:18 AM
File Not Attached
Subscribers
None

Description

[web] Show a popup when client_version_unsupported

Summary:
issue: [[ https://linear.app/comm/issue/ENG-6128/\[web\]-add-a-ui-element-to-inform-the-user-that-the-client-version-is | ENG-6128 ]]
The text is based on the text shown on native:

'App out of date',
message:
  'Your app version is pretty old, and the server doesn’t know how ' +
  `to speak to it anymore. Please use the ${platformStore} to update!`,

Screenshot 2024-04-11 at 16.47.54.png (1×1 px, 103 KB)

Note that I didn't have any designs for this, so if you think this doesn't look right, let me know!

EDIT:
After some review the modal now looks like this:

image.png (900×1 px, 88 KB)

Test Plan:
Tested that if the server sends client_version_unsupported the modal shows up.
Tested that it works on web and desktop

image.png (1×2 px, 1 MB)

Reviewers: tomek, ginsu, ashoat

Reviewed By: ashoat

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D11643

Details

Provenance
inkaAuthored on Apr 12 2024, 1:36 AM
Reviewer
ashoat
Differential Revision
D11643: [web] Show a popup when client_version_unsupported
Parents
rCOMM7b3fd475e97a: [lib][web][native] Pass preRequestUserState into invalidSessionRecovery
Branches
Unknown
Tags
Unknown