HomePhabricator
Diffusion Comm e5cb65cf5e8a

[lib] avoid listening to Tunnelbroker messages in `QRAuthProvider` when QR auth…

Description

[lib] avoid listening to Tunnelbroker messages in QRAuthProvider when QR auth is finished

Summary:
ENG-8385.

QR code login is not working right now. As described here (Point 3) and here the issue is occuring because of the fact that useQRAuth is unmounting before it can send SECONDARY_DEVICE_REGISTRATION_SUCCESS. This stack is refactoring the code to move logic to context (see here).

Make sure we no longer track Tunnelbroker messages here and avoid sending SECONDARY_DEVICE_REGISTRATION_SUCCESS multiple times (BACKUP_DATA_KEY_MESSAGE is the last message between devices).

Note that without scanning code listener is not added, so in normal app usage, listener code shouldn't be executed.

Depends on D12453

Test Plan: Test QR login flow on native and web

Reviewers: bartek, ashoat

Reviewed By: ashoat

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D12454

Details

Provenance
kamilAuthored on Jun 17 2024, 3:42 AM
Reviewer
ashoat
Differential Revision
D12454: [lib] avoid listening to Tunnelbroker messages in `QRAuthProvider` when QR auth is finished
Parents
rCOMM1844fb7c15f6: [native] remove `useQRAuth` hook
Branches
Unknown
Tags
Unknown