HomePhabricator
Diffusion Comm e614d0e05c6a

[native] Add `avatar` column to clientDB `threads` table

Tags
None
Referenced Files
F455941: 64daff.png
Apr 3 2023, 8:03 AM
File Not Attached
F455940: 30fc81.png
Apr 3 2023, 8:03 AM
File Not Attached
F455939: dcc448.png
Apr 3 2023, 8:03 AM
File Not Attached
Subscribers
None

Description

[native] Add avatar column to clientDB threads table

Summary:
We are adding an avatar column to the threads table in the clientDB and including an avatar field in the Thread struct. At the moment, the value of this field will always be NULL until we make some necessary changes. These changes involve modifying:

  1. The translation functions that convert between ClientDBThreadInfo and ThreadInfo.
  2. The C++ code responsible for constructing JSI ClientDBThreadInfo objects from the threads table rows retrieved from the database on the "JS side."

Once these changes have been made, we will be able to update the avatar field in the threads table and properly persist data in the new avatar column.

Test Plan:

  1. Verify that the migration was successful:

Before:

dcc448.png (708×514 px, 77 KB)

After:

30fc81.png (762×1 px, 90 KB)

64daff.png (162×1 px, 45 KB)

  1. Ensure that freshly created clientDB includes avatar column in the threads table:

Reviewers: ashoat, ginsu, kamil

Reviewed By: ashoat, kamil

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D7257

Details

Provenance
atulAuthored on Apr 3 2023, 7:16 AM
Reviewer
ashoat
Differential Revision
D7257: [native] Add `avatar` column to clientDB `threads` table
Parents
rCOMMcda2f4166325: [lib] Reducer for commServicesAccessToken
Branches
Unknown
Tags
Unknown