HomePhabricator
Diffusion Comm e8741e35c11a

[lib] Save unsupported operations in the DB

Description

[lib] Save unsupported operations in the DB

Summary:
The unsupported operations aren't saved in Redux, but it's still beneficial to use the same approach because it's more consistent, allows easier modification in the future (if we decide to keep all the operations in the DB, and avoids introducing a new mechanism.

https://linear.app/comm/issue/ENG-10329/create-a-new-action-and-modify-the-reducedmoperationsqueue-reducer

Depends on D14453

Test Plan:
Tested the whole stack on both native and web:

  1. Run the app on Redux version 86 with a modification to processDMOperation making all the INBOUND messages unsupported
  2. On one platform created a thread and sent a text message. These were visible on the sender, and invisible on the recipient
  3. Closed the recipient and added a migration that unshimms the thread creation operations, e.g.
unshimDMOperations(
  state,
  dmOperationTypes.CREATE_THREAD,
  handleReduxMigrationFailure,
): MigrationFunction<WebNavInfo, AppState>),
  1. Run the recipient and noticed the thread appearing
  2. Added another migration, this time unshimming text messages
  3. Run the recipient and noticed messages appearing

Reviewers: kamil, bartek

Reviewed By: kamil

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D14454

Details

Provenance
tomekAuthored on Fri, Mar 14, 7:22 AM
Reviewer
kamil
Differential Revision
D14454: [lib] Save unsupported operations in the DB
Parents
rCOMMdec6602b77a8: [lib] Handle ops in the reducer
Branches
Loading...
Tags
Loading...