Paths

Table of Contentst

[protos] Replace challengeResponse with nonce and signature pair
ecd0073aef88
Actions

Description

[protos] Replace challengeResponse with nonce and signature pair

Summary:
Addresses option 3 from ENG-7641.
Replaced challenge_response with separate nonce and nonce_signature fields.
Updated all usages

Depends on D11549

Test Plan:

Everything compiles
Updated unit and integration tests
Tested QR Auth on native and web

Reviewers: ashoat, varun

Reviewed By: ashoat, varun

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D11551

Details

Provenance

bartek

Authored on Thu, Apr 4, 6:55 AM

Reviewer

ashoat

Differential Revision

D11551: [protos] Replace challengeResponse with nonce and signature pair

Parents

rCOMMe7f9f1ef90fb: [protos] Remove social_proof from IdentityKeyInfo

Branches

Unknown

Tags

Unknown

Event Timeline

bartek committed rCOMMecd0073aef88: [protos] Replace challengeResponse with nonce and signature pair (authored by bartek).Mon, Apr 15, 1:43 AM

bartek added an edge: D11551: [protos] Replace challengeResponse with nonce and signature pair.

Changes (19)

Path

Size

lib/

types/

identity-service-types.js

native/

cpp/

CommonCpp/

NativeModules/

CommRustModule.cpp

CommRustModule.h

_generated/

rustJSI-generated.cpp

rustJSI.h

identity-service/

identity-service-context-provider.react.js

native_rust_library/

src/

identity/

lib.rs

qr-code/

qr-code-screen.react.js

schema/

CommRustModuleSchema.js

services/

commtest/

src/

identity/

mod.rs

tests/

identity_access_tokens_tests.rs

identity/

src/

client_service.rs

grpc_utils.rs

shared/

protos/

identity_unauth.proto

web/

account/

qr-code-login.react.js

grpc/

identity-service-client-wrapper.js

protobufs/

identity-unauth-structs.cjs

identity-unauth-structs.cjs.flow

rCOMMecd0073aef88

View Options

lib/types/identity-service-types.js

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI.h

View Options

native/identity-service/identity-service-context-provider.react.js

View Options

native/native_rust_library/src/identity/login.rs

View Options

native/native_rust_library/src/lib.rs

View Options

native/qr-code/qr-code-screen.react.js

View Options

native/schema/CommRustModuleSchema.js

View Options

services/commtest/src/identity/mod.rs

View Options

services/commtest/tests/identity_access_tokens_tests.rs

View Options

services/identity/src/client_service.rs

View Options

services/identity/src/grpc_utils.rs

View Options

shared/protos/identity_unauth.proto

View Options

web/account/qr-code-login.react.js

View Options

web/grpc/identity-service-client-wrapper.js

View Options

web/protobufs/identity-unauth-structs.cjs

View Options

web/protobufs/identity-unauth-structs.cjs.flow

[protos] Replace challengeResponse with nonce and signature pairecd0073aef88Actions

Description

Details

Event Timeline

Changes (19)

rCOMMecd0073aef88

lib/types/identity-service-types.js

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/identity-service/identity-service-context-provider.react.js

native/native_rust_library/src/identity/login.rs

native/native_rust_library/src/lib.rs

native/qr-code/qr-code-screen.react.js

native/schema/CommRustModuleSchema.js

services/commtest/src/identity/mod.rs

services/commtest/tests/identity_access_tokens_tests.rs

services/identity/src/client_service.rs

services/identity/src/grpc_utils.rs

shared/protos/identity_unauth.proto

web/account/qr-code-login.react.js

web/grpc/identity-service-client-wrapper.js

web/protobufs/identity-unauth-structs.cjs

web/protobufs/identity-unauth-structs.cjs.flow

[protos] Replace challengeResponse with nonce and signature pair
ecd0073aef88
Actions