HomePhabricator
Diffusion Comm eeedc177fa73

[native] [16/34] ReactNav6: clean up Navigator props

Description

[native] [16/34] ReactNav6: clean up Navigator props

Summary:

  1. Introduce new NavigatorProps type to Unify all of the different types that represent Navigator props
  2. Make sure screenListeners is included on NavigatorPropsBase and CreateNavigatorFactory, rather than only on CreateNavigator and the various *NavigatorProps types
  3. Introduce new ScreenListenersProp component with the same approach as ScreenOptionsProp
  4. Make corresponding changes to all three of our custom navigators, so that they match createStackNavigator upstream (defaultScreenOptions is still missing – will be addressed in a later diff)

Depends on D5408

Test Plan: Flow + ran the app on my phone and played around with it

Reviewers: atul, tomek, bartek

Reviewed By: atul

Subscribers: abosh

Differential Revision: https://phab.comm.dev/D5409

Details

Provenance
ashoatAuthored on Oct 18 2022, 9:25 AM
Reviewer
atul
Differential Revision
D5409: [native] [16/34] ReactNav6: clean up Navigator props
Parents
rCOMM4f73988bb362: [native] [15/34] ReactNav6: add navigator ID
Branches
Unknown
Tags
Unknown