HomePhabricator
Diffusion Comm f0e26cd283c1

[lib] Prevent spoiler text from appearing in notifications

Tags
None
Referenced Files
F268767: [A][Android] Bold Spoilers.png
Dec 1 2022, 8:21 PM
File Not Attached
F268766: [B][Android] Bold Spoiler.png
Dec 1 2022, 8:21 PM
File Not Attached
F268765: [A][iOS] Bold Spoiler.png
Dec 1 2022, 8:21 PM
File Not Attached
F268764: [B][iOS] Bold Spoiler.png
Dec 1 2022, 8:21 PM
File Not Attached
F268763: [A][Android] Multiple Spoilers.png
Dec 1 2022, 8:21 PM
File Not Attached
F268762: [B][Android] Multiple Spoilers.png
Dec 1 2022, 8:21 PM
File Not Attached
F268761: [A][iOS] Multiple Spoilers.png
Dec 1 2022, 8:21 PM
File Not Attached
F268760: [B][iOS] Multiple Spoilers.png
Dec 1 2022, 8:21 PM
File Not Attached
Subscribers
None

Description

[lib] Prevent spoiler text from appearing in notifications

Summary:
We want to hide spoilers from notifications on both iOS and Android. The context / discussion is on the Linear task:
https://linear.app/comm/issue/ENG-2056/prevent-spoiler-text-from-appearing-in-notifications-[native]

Test Plan:
Testing for both iOS and Android will be included once I can link screenshots here.

  1. This is a default message

iOS

[B][iOS] Default.png (2×1 px, 3 MB)

[A][iOS] Default.png (2×1 px, 3 MB)

Android
[B][Android] Default.png (1×1 px, 483 KB)

[A][Android] Default.png (1×1 px, 483 KB)

  1. This is a text with ||spoilers||

iOS

[B][iOS] One Spoiler.png (2×1 px, 3 MB)

[A][iOS] One Spoiler.png (2×1 px, 3 MB)

Android
[B][Android] One Spoiler.png (1×1 px, 484 KB)

[A][Android] One Spoiler.png (1×1 px, 483 KB)

  1. ||One|| and ||Two|| and Three

iOS

[B][iOS] Multiple Spoilers.png (2×1 px, 3 MB)

[A][iOS] Multiple Spoilers.png (2×1 px, 3 MB)

Android
[B][Android] Multiple Spoilers.png (1×1 px, 483 KB)

[A][Android] Multiple Spoilers.png (1×1 px, 481 KB)

  1. ||Bold Text||

iOS

[B][iOS] Bold Spoiler.png (2×1 px, 3 MB)

[A][iOS] Bold Spoiler.png (2×1 px, 3 MB)

Android
[B][Android] Bold Spoiler.png (1×1 px, 482 KB)

[A][Android] Bold Spoilers.png (1×1 px, 478 KB)

Reviewers: atul, ginsu, ashoat

Reviewed By: ashoat

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D5793

Details

Provenance
rohanAuthored on Dec 1 2022, 1:26 PM
Reviewer
ashoat
Differential Revision
D5793: [lib] Prevent spoiler text from appearing in notifications
Parents
rCOMM272876219926: [native] Prevent text from being highlighted on press when if is no pressable
Branches
Unknown
Tags
Unknown