HomePhabricator
Diffusion Comm f2f8d8d98931

[native] Don't crash native uploadBlob on JSON parse failure
f2f8d8d98931
Actions

Description

[native] Don't crash native uploadBlob on JSON parse failure

Summary: Me and @atul were debugging a crash that occurred when the server was down and realized that I never put a try-catch around this JSON.parse.

Test Plan: Made sure the crash stopped occurring

Reviewers: atul, palys-swm

Reviewed By: atul

Subscribers: KatPo, zrebcu411, Adrian, atul

Differential Revision: https://phabricator.ashoat.com/D587

Details

Provenance
ashoatAuthored on Jan 12 2021, 5:52 PM
Reviewer
atul
Differential Revision
Restricted Differential Revision
Parents
rCOMM48e6c28f548f: [native] Update default server URLs to use comm instead of squadcal
Branches
Unknown
Tags
Unknown

Event Timeline

ashoat committed rCOMMf2f8d8d98931: [native] Don't crash native uploadBlob on JSON parse failure (authored by ashoat).Jan 12 2021, 5:53 PM
ashoat added an edge: Restricted Differential Revision.
ashoat added a subscriber: atul.

Changes (1)

PathSize
native/
input/

rCOMMf2f8d8d98931

View Options

native/input/input-state-container.react.js

Loading...