HomePhabricator
Diffusion Comm facbb98adda5

[Flow202][native][skip-ci] [15/x] Move unboundStyles to the top

Description

[Flow202][native][skip-ci] [15/x] Move unboundStyles to the top

Summary:
Flow was printing errors like this:

Error ------------------------------------------------------------------------- account/logged-out-modal.react.js:144:19

Cannot use variable unboundStyles [1] because the declaration either comes later or was skipped.
[reference-before-declaration]

     141|   +loggedIn: boolean,
     142|   +dimensions: DerivedDimensionsInfo,
     143|   +splashStyle: ImageStyle,
     144|   +styles: typeof unboundStyles,
     145|   // Redux dispatch functions
     146|   +dispatch: Dispatch,
     147|   // Keyserver olm sessions functions
        :
 [1] 692| const unboundStyles = {

To address it I moved all of the unboundStyles definitions above their corresponding typeof invocations.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9998

Test Plan: Confirm the Flow errors go away

Reviewers: atul, tomek, ginsu

Reviewed By: tomek

Differential Revision: https://phab.comm.dev/D9999

Details

Provenance
ashoatAuthored on Nov 15 2023, 5:51 PM
Reviewer
tomek
Differential Revision
D9999: [Flow202][native][skip-ci] [15/x] Move unboundStyles to the top
Parents
rCOMM60fd22c61b4b: [Flow202][native][skip-ci] [14/x] Fix Flow issues with useDispatch /…
Branches
Unknown
Tags
Unknown