Page MenuHomePhabricator

[blob] Add option to instantly delete a blob
ClosedPublic

Authored by bartek on Dec 1 2023, 7:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 7:32 AM
Unknown Object (File)
Wed, Nov 13, 7:32 AM
Unknown Object (File)
Wed, Nov 13, 7:31 AM
Unknown Object (File)
Wed, Nov 13, 7:31 AM
Unknown Object (File)
Sat, Nov 2, 9:35 AM
Unknown Object (File)
Oct 11 2024, 11:51 PM
Unknown Object (File)
Oct 11 2024, 11:51 PM
Unknown Object (File)
Oct 11 2024, 11:50 PM
Subscribers

Details

Summary

Resolves ENG-5580.

Added a instant_delete option to the DELETE request payload. If set to true, the blob will be deleted immediately after last holder is revoked. Otherwise, it will be deleted during the next cleanup run.

The DELETE request payload now looks like this:

{
  holder: "some_holder",
  blob_hash: "some_hash",
  // defaults to false if not provided
  instant_delete: true
}
Test Plan

1a. Started blob without --instant-delete flag. Uploaded a blob, revoked a holder, then ensured it is still accessible with GET request. (did not run a cleanup job)
1b. Ran a cleanup job, ensured the blob is deleted.

  1. Started blob with --instant-delete flag. Uploaded a blob, revoked a holder, then ensured it is not accessible with GET request. (did not run a cleanup job)
  2. Started blob with --instant-delete flag. Uploaded a blob, revoked a holder by using DELETE request with instant_delete set to true, result is the same as in 2.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable