Paths

Table of Contentst

[lib] Remove unnecessary code
ClosedPublic
Actions

Authored by inka on Dec 11 2023, 2:56 AM.

Tags

None

Referenced Files

	F3768302: D10289.id34472.diff
	Sun, Jan 12, 3:35 AM

	F3768301: D10289.id34470.diff
	Sun, Jan 12, 3:35 AM

	F3768300: D10289.id.diff
	Sun, Jan 12, 3:35 AM

	F3768294: D10289.diff
	Sun, Jan 12, 3:34 AM

	Unknown Object (File)
	Nov 27 2024, 5:13 AM

	Unknown Object (File)
	Nov 27 2024, 3:50 AM

	Unknown Object (File)
	Nov 27 2024, 1:03 AM

	Unknown Object (File)
	Nov 17 2024, 9:56 PM

View All 55 Files

Subscribers

ashoat

tomek

Details

Reviewers

michal

Commits

rCOMMe49e478c7697: [lib] Remove unnecessary code

Summary

Since D9500 sessionChange is obligatory in AuthErrorServerSocketMessage. This was dead code.

Test Plan

flow. I checked all places where AUTH_ERROR is returned by the keyserver. They do indeed all specify sessionChange.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Dec 11 2023, 2:56 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 11 2023, 2:56 AM

inka mentioned this in D10287: [lib] Add connectionIssue field.Dec 11 2023, 2:57 AM

Harbormaster completed remote builds in B24936: Diff 34470.Dec 11 2023, 3:16 AM

inka requested review of this revision.Dec 11 2023, 3:16 AM

michal accepted this revision.Dec 11 2023, 3:31 AM

This revision is now accepted and ready to land.Dec 11 2023, 3:31 AM

Closed by commit rCOMMe49e478c7697: [lib] Remove unnecessary code (authored by inka). · Explain WhyDec 11 2023, 5:27 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMe49e478c7697: [lib] Remove unnecessary code.

Revision Contents
Changeset List

Path

Size

lib/

socket/

socket.react.js

7 lines

Diff 34472

View Options

lib/socket/socket.react.js

[lib] Remove unnecessary codeClosedPublicActions