Page MenuHomePhabricator

[web] improve error handling when setting/getting userID
ClosedPublic

Authored by kamil on Dec 12 2023, 1:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 7, 3:37 AM
Unknown Object (File)
Thu, Jul 4, 12:12 PM
Unknown Object (File)
Sun, Jun 30, 11:24 AM
Unknown Object (File)
Thu, Jun 27, 2:57 AM
Unknown Object (File)
Thu, Jun 27, 12:07 AM
Unknown Object (File)
Tue, Jun 25, 9:25 AM
Unknown Object (File)
Sun, Jun 23, 11:26 PM
Unknown Object (File)
Sun, Jun 23, 11:26 PM
Subscribers

Details

Summary
  1. Making errors more descriptive
  2. When we cannot not get userID we should delete database
Test Plan
  1. Throw errors from setting/getting userID and check if errors are printed.
  2. Throw error from getting and make sure database is deleted

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Dec 13 2023, 2:03 AM
tomek requested changes to this revision.Dec 13 2023, 4:59 AM
tomek added inline comments.
web/database/sqlite-data-handler.js
43–59 ↗(On Diff #34514)

It is possible that await databaseModule.init({ clearDatabase: true }); will throw and we catch it, and then

await databaseModule.schedule({
          type: workerRequestMessageTypes.SET_CURRENT_USER_ID,
          userID: currentLoggedInUserID,
        });

will succeed... won't that result in assigning a new user to the old data?

This revision now requires changes to proceed.Dec 13 2023, 4:59 AM

ealry return on clearing data failure

web/database/sqlite-data-handler.js
43–59 ↗(On Diff #34514)

yes, good catch, fixed

This revision is now accepted and ready to land.Dec 15 2023, 6:25 AM