[web] avoid initializing already initialized WASM module
ClosedPublic
Actions

Authored by kamil on Dec 22 2023, 1:45 AM.

Details

Reviewers

michal
tomek

Commits

rCOMMb7b127fcc50b: [web] avoid initializing already initialized WASM module

Summary

Context in ENG-6276.

Test Plan

Open multiple tabs and make sure DB is initialized only once
Log out and make sure it works (in that case we have WASM module, but don't have SQLiteQueryExecutor)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Dec 22 2023, 1:45 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 22 2023, 1:46 AM

Harbormaster completed remote builds in B25313: Diff 34966.Dec 22 2023, 2:03 AM

kamil published this revision for review.Dec 22 2023, 2:13 AM

kamil edited the summary of this revision. (Show Details)

kamil edited the test plan for this revision. (Show Details)

tomek accepted this revision.Dec 22 2023, 3:03 AM

tomek added inline comments.

web/database/worker/db-worker.js
61–66 ↗	(On Diff #34966)	Isn't it equivalent to the suggested code?

This revision is now accepted and ready to land.Dec 22 2023, 3:03 AM

kamil added inline comments.Dec 22 2023, 4:48 AM

web/database/worker/db-worker.js
61–66 ↗	(On Diff #34966)	yes but flow is complaining if we want to use `dbModule` later in the code

Closed by commit rCOMMb7b127fcc50b: [web] avoid initializing already initialized WASM module (authored by kamil). · Explain WhyDec 22 2023, 4:50 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMb7b127fcc50b: [web] avoid initializing already initialized WASM module.

Revision Contents
Changeset List

Path

Size

web/

database/

worker/

db-worker.js

16 lines

Diff 34968

View Options

web/database/worker/db-worker.js

[web] avoid initializing already initialized WASM moduleClosedPublicActions