Details
Details
- I created a Phabricator leaderboard thread in my local environment
- I changed phabLeaderboardChannel with the value of that thread ID
- I patched postLeaderboard to test the behavior on January 2024
- yarn script dist/scripts/phab-leaderboard.js
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| keyserver/src/cron/phab-leaderboard.js | ||
|---|---|---|
| 107 ↗ | (On Diff #35046) | This table has one entry for every "diff" (eg. D10468). Technically they are called "revisions" |
| 108–109 ↗ | (On Diff #35046) | This is where we get the author of the revision |
| 110–112 ↗ | (On Diff #35046) | Same as previous diff: https://phab.comm.dev/D10468#inline-63770 |
| 113 ↗ | (On Diff #35046) | Same as previous diff: https://phab.comm.dev/D10468#inline-63771 |
Comment Actions
If I'm understanding this query correctly, we're counting the number of differential.revision.close transactions. Not sure if this is a big deal, but I believe if someone were to
- Land a diff
- Revert that diff
- Re-open that diff
- Re-land that diff
We would see two differential.revision.close?
Could we change COUNT(r.id) to COUNT(DISTINCT r.id) to handle this so that each diff (differential.revision) is only counted once?
(Didn't read the query too carefully, so apologize if I'm missing something.)