Paths

Table of Contentst

[native] Support Blob service URIs when saving media
ClosedPublic
Actions

Authored by bartek on Feb 1 2024, 1:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 13, 2:35 PM

	Unknown Object (File)
	Apr 18 2024, 8:55 AM

	Unknown Object (File)
	Apr 18 2024, 8:55 AM

	Unknown Object (File)
	Apr 18 2024, 8:55 AM

	Unknown Object (File)
	Apr 18 2024, 8:55 AM

	Unknown Object (File)
	Feb 29 2024, 12:57 PM

	Unknown Object (File)
	Feb 28 2024, 7:10 PM

	Unknown Object (File)
	Feb 27 2024, 12:58 PM

View All 17 Files

Subscribers

ashoat

tomek

Details

Reviewers

atul
ashoat

Commits

rCOMMd7c235d46ec2: [native] Support Blob service URIs when saving media

Summary

Missing part of D10854. I realized that Blob Service stored media URIs start with blob-service:// and are not recognized by current code. This diff fixes that.

Test Plan

Enable blob service uploads in input-state-container
Send a photo message
Open the photo modal and click save

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Feb 1 2024, 1:23 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 1 2024, 1:23 AM

bartek published this revision for review.Feb 1 2024, 1:41 AM

Harbormaster completed remote builds in B26398: Diff 36500.Feb 1 2024, 1:44 AM

Accepting here instead of @atul to speed up landing

Weird that this shows up as "In Review" still

This revision is now accepted and ready to land.Feb 2 2024, 6:57 AM

Closed by commit rCOMMd7c235d46ec2: [native] Support Blob service URIs when saving media (authored by bartek). · Explain WhyFeb 2 2024, 6:58 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMd7c235d46ec2: [native] Support Blob service URIs when saving media.

Revision Contents
Changeset List

Path

Size

native/

media/

save-media.js

5 lines

Diff 36592

View Options

native/media/save-media.js

[native] Support Blob service URIs when saving mediaClosedPublicActions