Page MenuHomePhabricator
Differential D11012

[lib] Pass keyserverID to Socket
ClosedPublic
Actions

Authored by ashoat on Feb 9 2024, 8:23 AM.
Tags
None
Referenced Files
F2183857: D11012.id.diff
Wed, Jul 3, 8:14 PM
Unknown Object (File)
Wed, Jul 3, 8:15 AM
Unknown Object (File)
Mon, Jul 1, 3:48 AM
Unknown Object (File)
Fri, Jun 14, 12:54 AM
Unknown Object (File)
Mon, Jun 10, 12:41 PM
Unknown Object (File)
Wed, Jun 5, 3:06 AM
Unknown Object (File)
May 24 2024, 2:05 AM
Unknown Object (File)
May 24 2024, 2:05 AM
View All 23 Files
Subscribers
None

Details

Reviewers
inka
tomek
Commits
rCOMM4698b8e2084e: [lib] Pass keyserverID to Socket
Summary

In the next diff, I'll use this keyserverID in place of ashoatKeyserverID. This will be a no-op, since KeyserverConnectionHandler currently only renders a Socket when keyserverID === ashoatKeyserverID.

Test Plan
  1. Flow
  2. Careful inspection of the code

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 9 2024, 8:23 AM
ashoat added a child revision: D11013: [lib][native][web] Replace ashoatKeyserverID in Socket code with keyserverID.
ashoat published this revision for review.Feb 9 2024, 8:24 AM

Will confirm CI is green before landing

ashoat added inline comments.Feb 9 2024, 8:25 AM
lib/socket/socket.react.js
83 ↗(On Diff #36936)

It may be easiest to start the review on this line

Harbormaster failed remote builds in B26712: Diff 36936!Feb 9 2024, 8:27 AM
inka accepted this revision.Feb 9 2024, 8:37 AM
This revision is now accepted and ready to land.Feb 9 2024, 8:37 AM
ashoat mentioned this in D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.Feb 9 2024, 8:41 AM

Relevant CI is green, so I'll land this now. The red CIs are due to ENG-6717

This revision was landed with ongoing or failed builds.Feb 9 2024, 8:43 AM
Closed by commit rCOMM4698b8e2084e: [lib] Pass keyserverID to Socket (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM4698b8e2084e: [lib] Pass keyserverID to Socket.

Revision Contents
Changeset List

Diff 36940

View Options

lib/components/keyserver-connection-handler.js

Loading...
View Options

lib/components/keyserver-connections-handler.js

Loading...
View Options

lib/socket/socket.react.js

Loading...