Page MenuHomePhabricator

[lib][web] Bring back eslint-disable-next-line for keyserver relative import in Webpack config
AbandonedPublicDraft

Authored by ashoat on Feb 12 2024, 9:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 3, 1:00 PM
Unknown Object (File)
Thu, Oct 3, 1:00 PM
Unknown Object (File)
Thu, Oct 3, 1:00 PM
Unknown Object (File)
Tue, Sep 10, 8:52 AM
Unknown Object (File)
Aug 29 2024, 7:05 AM
Unknown Object (File)
Aug 11 2024, 9:32 AM
Unknown Object (File)
Aug 11 2024, 9:32 AM
Unknown Object (File)
Aug 11 2024, 9:31 AM
Subscribers

Details

Reviewers
atul
Summary

These eslint-disable-next-line declarations were removed in D10542, which was a diff that was automatically generated by running ESLint after adding --report-unused-disable-directives.

Not sure why, but the ESLint errors are showing up again for me. It seems like these errors are "unstable" (sometimes fire and sometimes not)... if that's the case, I think it's better to leave the ignore declarations in, than to take them out.

Test Plan

yarn eslint:fix at the repo root

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/webpack
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2024, 10:03 PM
Harbormaster failed remote builds in B26773: Diff 37013!

I guess this is a bad idea since it breaks CI. Annoying that this rule is unstable