[lib] Include KeyserverAuthResult payload for KEYSERVER_AUTH_SUCCESS
ClosedPublic
Actions

Authored by ashoat on Feb 13 2024, 11:55 AM.

Details

Reviewers

tomek
inka

Commits

rCOMM5bb779594dd2: [lib] Include KeyserverAuthResult payload for KEYSERVER_AUTH_SUCCESS

Summary

Based on types in lib/types/redux-types.js, it should not be possible to dispatch KEYSERVER_AUTH_SUCCESS with payload being undefined. Not sure if this was intentionally left out... if so, should we consider updating the types to match?

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/returnkeyserverauthresult

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 13 2024, 11:55 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 13 2024, 12:15 PM

Harbormaster failed remote builds in B26797: Diff 37038!

Harbormaster completed remote builds in B26797: Diff 37038.Feb 14 2024, 10:13 AM

ashoat requested review of this revision.Feb 14 2024, 10:13 AM

It wasn't intentional. Thanks for fixing it!

This revision is now accepted and ready to land.Feb 15 2024, 3:36 AM

Closed by commit rCOMM5bb779594dd2: [lib] Include KeyserverAuthResult payload for KEYSERVER_AUTH_SUCCESS (authored by ashoat). · Explain WhyFeb 15 2024, 7:26 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5bb779594dd2: [lib] Include KeyserverAuthResult payload for KEYSERVER_AUTH_SUCCESS.

Revision Contents
Changeset List

Path

Size

lib/

components/

keyserver-connection-handler.js

3 lines

Diff 37038

View Options

lib/components/keyserver-connection-handler.js

[lib] Include KeyserverAuthResult payload for KEYSERVER_AUTH_SUCCESSClosedPublicActions