Page MenuHomePhabricator

[native] Fix hermes throwing on nonexistant files
ClosedPublic

Authored by inka on Feb 23 2024, 7:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 4 2024, 5:33 AM
Unknown Object (File)
Mar 29 2024, 7:28 PM
Unknown Object (File)
Mar 6 2024, 7:55 PM
Unknown Object (File)
Mar 4 2024, 12:33 PM
Unknown Object (File)
Mar 1 2024, 5:19 PM
Unknown Object (File)
Mar 1 2024, 11:22 AM
Unknown Object (File)
Mar 1 2024, 11:09 AM
Unknown Object (File)
Feb 28 2024, 12:21 PM
Subscribers

Details

Summary
Test Plan

tested that if the file doesn't exist authoritativeKeyserverID is 256 and it is possible to logout and back in
Tested that if the file exists and authoritativeKeyserverID is correctly set

Checked that

const {
    authoritativeKeyserverID: keyserverID,
    // $FlowExpectedError: file might not exist
  } = require('./facts/authoritative_keyserver.json');

throws if the file doesn't exist, so authoritativeKeyserverID is not being set to undefined

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 23 2024, 7:15 AM
Harbormaster failed remote builds in B27112: Diff 37520!
inka requested review of this revision.Feb 23 2024, 7:17 AM
This revision is now accepted and ready to land.Feb 23 2024, 7:17 AM

The build fails because of https://linear.app/comm/issue/ENG-6910/buildkite-ios-build-failing-on-canal-runner#comment-05ad83c2

This is a fix for an urgent issue, so I will land it with this build failing

This revision was landed with ongoing or failed builds.Feb 23 2024, 7:38 AM
This revision was automatically updated to reflect the committed changes.