[lib] Log out when invalidating session with authoritative keyserver in useKeyserverRecoveryLogIn
ClosedPublic
Actions

Authored by ashoat on Mar 6 2024, 4:26 PM.

Details

Reviewers

inka
tomek

Commits

rCOMMbfe4ccc6f1fb: [lib] Log out when invalidating session with authoritative keyserver in…

Summary

This was discussed in ENG-7133.

Note that on web, keyserver session aren't currently invalidated via useKeyserverRecoveryLogIn, as we aren't able to attempt recovery since it depends on having access to user credentials. This will no longer be the case following the identity service launch, since user credentials will no longer be necessary for attempting keyserver session recovery. As such, I'm not going to bother doing anything special for web, since it will be supported via this mechanism relatively soon.

Depends on D11264

Test Plan

I hacked legacy-recover-keyserver-session.js to use the wrong password so the session recovery would fail
I started the iOS simulator and logged in using a test user
I opened the Redux Dev Tools
I deleted the test user's cookie from the MariaDB database: DELETE FROM cookies WHERE user = 6390578 AND platform = 'ios'
I sent a message as the test user
I confirmed that session recovery was triggered in the Redux dev tools
I confirmed that after session recovery failed, the user was logged out in the UI
Via Redux dev tools, I confirmed that after session recovery failed, LOG_OUT_STARTED and LOG_OUT_SUCCESS were dispatched

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 6 2024, 4:26 PM

ashoat retitled this revision from t log[lib] Log out when invalidating session with authoritative keyserver in useKeyserverRecoveryLogIn to [lib] Log out when invalidating session with authoritative keyserver in useKeyserverRecoveryLogIn.Mar 6 2024, 4:26 PM

ashoat added inline comments.

lib/components/keyserver-connection-handler.js
92 ↗	(On Diff #37910)	Snuck this fix in

Harbormaster completed remote builds in B27373: Diff 37910.Mar 6 2024, 4:41 PM

ashoat requested review of this revision.Mar 6 2024, 4:41 PM

inka added inline comments.Mar 7 2024, 12:36 AM

lib/keyserver-conn/recovery-utils.js
184–191 ↗	(On Diff #37910)	Why do we want to dispatch this even if logout is dispatched?

ashoat added inline comments.Mar 7 2024, 5:50 PM

lib/keyserver-conn/recovery-utils.js
184–191 ↗	(On Diff #37910)	It felt like a more risky change to remove this. In some cases, such as `keyserver-reducer.js`, data is not updated until `logOutActionTypes.success` is processed, which has some delay. In contrast, `setNewSessionActionType` is processed immediately