Page MenuHomePhabricator

[lib] Don't invalidate a session if the recovery is cancelled
ClosedPublic

Authored by ashoat on Mar 31 2024, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 4:32 PM
Unknown Object (File)
Apr 7 2024, 8:31 PM
Unknown Object (File)
Apr 7 2024, 9:31 AM
Unknown Object (File)
Apr 6 2024, 10:04 AM
Unknown Object (File)
Apr 3 2024, 1:06 AM
Unknown Object (File)
Apr 3 2024, 1:06 AM
Unknown Object (File)
Apr 3 2024, 1:05 AM
Unknown Object (File)
Apr 3 2024, 1:04 AM
Subscribers
None

Details

Summary

Discovered this issue while testing keyserverAuth-based recovery. We should wait until a non-cancelled recovery fails in order to invalidate the session.

I suspect I hadn't encountered it in prior testing because before introducing keyserverAuth to the dep list, the recovery was unlikely to get cancelled before it ran its course.

Test Plan

Confirm that a cancelled keyserver session recovery doesn't invalidate the session

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable