Details
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/data/sqlite-data-handler.js | ||
|---|---|---|
| 150 | The new changes will make this code clear the SQLite database when EITHER the authoritative keyserver cookie OR the currentUserInfo is unset. Theoretically that means the SQLite database might be cleared sooner or more often than before, but in practice I think it will be the same as before. The code in KeyserverConnectionHandler should make sure that we trigger a log out if the authoritative keyserver cookie is invalidated. Note that this should not prevent keyserver session recovery, since we defer invalidating the authoritative keyserver cookie in Redux until the recover fails | |
| 155 | ||
| native/data/sqlite-data-handler.js | ||
|---|---|---|
| 141–143 | can we use isLoggedInToKeyserver? | |
| native/data/sqlite-data-handler.js | ||
|---|---|---|
| 155 | Yes, I think we should keep them consistent. | |
More context in the task, but I'm abandoning this approach in favor of another, more idiomatic/clean one
| native/data/sqlite-data-handler.js | ||
|---|---|---|
| 155 | I'll put up a separate diff for this | |
| native/data/sqlite-data-handler.js | ||
|---|---|---|
| 155 | ||