Paths

Table of Contentst

Differential D11688

[native] Purge the store after clearing the DB
ClosedPublic
Actions

Authored by tomek on Thu, Apr 18, 7:36 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 26, 7:10 PM

	Unknown Object (File)
	Fri, Apr 26, 11:21 AM

	Unknown Object (File)
	Fri, Apr 26, 10:19 AM

	Unknown Object (File)
	Fri, Apr 26, 8:26 AM

	Unknown Object (File)
	Wed, Apr 24, 10:20 AM

	Unknown Object (File)
	Tue, Apr 23, 11:36 PM

	Unknown Object (File)
	Thu, Apr 18, 6:25 PM

	Unknown Object (File)
	Thu, Apr 18, 6:25 PM

View All 10 Files

Subscribers

Details

Reviewers

kamil
inka

Commits

rCOMMb1050c45b384: [native] Purge the store after clearing the DB

Summary

clearSensitiveData clears the token, which causes an event to be emitted, which causes AccessTokenHandler to dispatch a new action. This action is dispatched after the store is purged and causes a new state to be persisted. The solution is to purge after the clearing of the DB is finished.

https://linear.app/comm/issue/ENG-7788/state-difference-after-state-wipe

Test Plan

Wipe the state, start the app - there should be no state diff.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Thu, Apr 18, 7:36 AM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Apr 18, 7:36 AM

Harbormaster completed remote builds in B28294: Diff 39218.Thu, Apr 18, 7:52 AM

tomek requested review of this revision.Thu, Apr 18, 7:52 AM

kamil accepted this revision.Thu, Apr 18, 8:26 AM

This revision is now accepted and ready to land.Thu, Apr 18, 8:26 AM

Closed by commit rCOMMb1050c45b384: [native] Purge the store after clearing the DB (authored by tomek). · Explain WhyThu, Apr 18, 9:12 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMb1050c45b384: [native] Purge the store after clearing the DB.

Revision Contents
Changeset List

Path

Size

native/

redux/

4 lines

utils/

2 lines

Diff 39226

native/redux/persist.js

Loading...

native/utils/crash-utils.js

Loading...