Page MenuHomePhabricator
Differential D11698

[lib] Move uploadBlob to lib/keyserver-conn
ClosedPublic
Actions

Authored by ashoat on Fri, Apr 19, 8:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 11:54 PM
Unknown Object (File)
Thu, May 2, 1:10 AM
Unknown Object (File)
Fri, Apr 26, 5:12 PM
Unknown Object (File)
Fri, Apr 26, 9:58 AM
Unknown Object (File)
Wed, Apr 24, 1:03 PM
Unknown Object (File)
Tue, Apr 23, 2:48 PM
Unknown Object (File)
Mon, Apr 22, 9:24 AM
Unknown Object (File)
Fri, Apr 19, 10:30 AM
View All 10 Files
Subscribers
None

Details

Reviewers
tomek
inka
Commits
rCOMM34e9d5b1913b: [lib] Move uploadBlob to lib/keyserver-conn
Summary

Now that callSingleKeyserverEndpoint has been moved, it makes sense to move uploadBlob too, since it's primarily used from callSingleKeyserverEndpoint.

Depends on D11697

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Fri, Apr 19, 8:33 AM
ashoat added a child revision: D11699: [lib][web] Move useKeyserverCall to lib/keyserver-conn.
Harbormaster completed remote builds in B28327: Diff 39282.Fri, Apr 19, 8:56 AM
ashoat requested review of this revision.Fri, Apr 19, 8:56 AM
tomek accepted this revision.Fri, Apr 19, 10:11 AM
tomek added inline comments.
lib/keyserver-conn/upload-blob.js
12 ↗(On Diff #39282)

We can consider renaming it to avoid confusion with blobs from blob service.

This revision is now accepted and ready to land.Fri, Apr 19, 10:11 AM
ashoat added inline comments.Fri, Apr 19, 11:08 AM
lib/keyserver-conn/upload-blob.js
12 ↗(On Diff #39282)

Okay, but I'll do this in a separate diff as it's somewhat involved, and I think it's best to leave this diff as a "pure move"

Closed by commit rCOMM34e9d5b1913b: [lib] Move uploadBlob to lib/keyserver-conn (authored by ashoat). · Explain WhyFri, Apr 19, 11:12 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM34e9d5b1913b: [lib] Move uploadBlob to lib/keyserver-conn.
ashoat added inline comments.Fri, Apr 19, 11:49 AM
lib/keyserver-conn/upload-blob.js
12 ↗(On Diff #39282)

D11703

Revision Contents
Changeset List

PathSize
lib/
actions/
2 lines
keyserver-conn/
2 lines
keyserver-conn/
utils/
4 lines
utils/

Diff 39296

View Options

lib/actions/upload-actions.js

Loading...
View Options

lib/keyserver-conn/call-single-keyserver-endpoint.js

Loading...
View Options

lib/keyserver-conn/upload-blob.js

Loading...
View Options

lib/utils/upload-blob.js

Loading...