Page MenuHomePhabricator

[keyserver] Use keyserverID instead of userID when creating invite link blobs
ClosedPublic

Authored by tomek on Apr 22 2024, 4:49 AM.
Tags
None
Referenced Files
F3384390: D11708.diff
Thu, Nov 28, 8:51 PM
Unknown Object (File)
Fri, Nov 8, 10:35 PM
Unknown Object (File)
Fri, Nov 8, 1:41 PM
Unknown Object (File)
Fri, Nov 8, 7:14 AM
Unknown Object (File)
Fri, Nov 8, 7:14 AM
Unknown Object (File)
Oct 20 2024, 5:59 AM
Unknown Object (File)
Oct 17 2024, 2:12 PM
Unknown Object (File)
Oct 12 2024, 8:36 PM
Subscribers

Details

Summary

For each link we create a blob that contains a keyserver ID that is later used as a part of the override on the client side. In a single-keyserver world, this value should be equal to 256 because this is the ID a client uses as a keyserver ID. Instead of using the correct value, we were using the ID of a user, taken from Identity - so it was a multi-keyserver keyserver ID.

This issue wasn't affecting prod because the ID of the keyserver on prod Identity is equal to 256.

https://linear.app/comm/issue/ENG-7789/invite-links-in-single-keyserver-world-fail

Test Plan

Tested if creating a new link and accepting it works with both single- and multi-keyserver IDs. (testing multi-keyserver ID was performed by having a client with usingCommservicesAccessToken set to false, and a keyserver with usingIdentityCredentials set to true).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable