Paths

Table of Contentst

Differential D11736

[lib] Fix error when deleting a keyserver
ClosedPublic
Actions

Authored by inka on Tue, Apr 23, 4:02 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 1, 3:23 PM

	Unknown Object (File)
	Sun, Apr 28, 10:18 PM

	Unknown Object (File)
	Sun, Apr 28, 8:38 PM

	Unknown Object (File)
	Fri, Apr 26, 5:06 PM

	Unknown Object (File)
	Tue, Apr 23, 7:20 PM

	Unknown Object (File)
	Tue, Apr 23, 7:20 PM

	Unknown Object (File)
	Tue, Apr 23, 7:19 PM

	Unknown Object (File)
	Tue, Apr 23, 7:17 PM

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMM69c181651591: [lib] Fix error when deleting a keyserver

Summary

issue: ENG-7174
Deleting a keyserver would result in the app crashing, because updateConnectionStatusActionType would be dispatched for the removed keyserver.
We should just ignore this action. This happens because of unfortunate ordering - the keyserver is removed, and before the socket is unmounted the action gets dispatched

Test Plan

Tested that after this the app no longer crashes after removing a keyserver from the keyserver list.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Tue, Apr 23, 4:02 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Apr 23, 4:02 AM

inka added reviewers: tomek, kamil.Tue, Apr 23, 4:03 AM

Harbormaster completed remote builds in B28398: Diff 39393.Tue, Apr 23, 4:17 AM

inka requested review of this revision.Tue, Apr 23, 4:17 AM

tomek accepted this revision.Tue, Apr 23, 4:24 AM

This revision is now accepted and ready to land.Tue, Apr 23, 4:24 AM

Closed by commit rCOMM69c181651591: [lib] Fix error when deleting a keyserver (authored by inka). · Explain WhyTue, Apr 23, 4:56 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM69c181651591: [lib] Fix error when deleting a keyserver.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

keyserver-reducer.js

6 lines

Diff 39397

lib/reducers/keyserver-reducer.js

Loading...