Page MenuHomePhabricator
Differential D11860

[web] differentiate between password and wallet users in MissingCSATModal
ClosedPublic
Actions

Authored by varun on Thu, May 2, 9:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 2:36 AM
Unknown Object (File)
Sun, May 12, 3:34 PM
Unknown Object (File)
Sun, May 12, 10:42 AM
Unknown Object (File)
Thu, May 9, 6:15 PM
Unknown Object (File)
Thu, May 9, 2:59 PM
Unknown Object (File)
Thu, May 9, 10:17 AM
Unknown Object (File)
Tue, May 7, 2:30 PM
Unknown Object (File)
Sun, May 5, 11:39 PM
View All 13 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
Commits
rCOMM65d6768c3ff8: [web] differentiate between password and wallet users in MissingCSATModal
Summary

Depends on D11844

@ashoat and I realized earlier this week that we need to differentiate between wallet and password users when deciding what to display in the modal when a user is logged out.

came up with this copy for wallet users (to whom PAKE is not relevant)

Test Plan

Wallet user:

Screenshot 2024-05-01 at 12.51.51 AM.png (1×2 px, 143 KB)

Password user:

Screenshot 2024-04-30 at 12.51.19 PM.png (1×1 px, 154 KB)

same test plan as in prior diffs but with wallet and password users, to ensure both modals are displayed correctly. see above images

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Thu, May 2, 9:29 PM
Herald added a subscriber: tomek. · View Herald TranscriptThu, May 2, 9:29 PM
varun edited the test plan for this revision. (Show Details)Thu, May 2, 9:29 PM
varun edited the test plan for this revision. (Show Details)
varun attached a referenced file: F1694163: Screenshot 2024-04-30 at 12.51.19 PM.png. (Show Details)
varun attached a referenced file: F1694164: Screenshot 2024-05-01 at 12.51.51 AM.png. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Thu, May 2, 9:39 PM
Harbormaster failed remote builds in B28635: Diff 39753!
varun requested review of this revision.Thu, May 2, 10:10 PM

iOS build failure looks unrelated

ashoat added inline comments.Thu, May 2, 10:19 PM
web/components/log-out-if-missing-csat-handler.react.js
23–40 ↗(On Diff #39753)

Can we avoid ternary here? https://www.notion.so/commapp/Use-ternary-conditionals-sparingly-f4ba44a10259403592a1d15440a9847e

56–58 ↗(On Diff #39753)

Why load this here and pass it in instead of just loading it in MissingCSATModal?

varun added inline comments.Thu, May 2, 10:29 PM
web/components/log-out-if-missing-csat-handler.react.js
56–58 ↗(On Diff #39753)

i tried that first, but because the user gets logged out, the selector always returns false and we only see the wallet user message in the modal

ashoat accepted this revision.Thu, May 2, 10:52 PM
This revision is now accepted and ready to land.Thu, May 2, 10:52 PM
This revision was landed with ongoing or failed builds.Sun, May 5, 5:29 PM
Closed by commit rCOMM65d6768c3ff8: [web] differentiate between password and wallet users in MissingCSATModal (authored by varun). · Explain Why
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM65d6768c3ff8: [web] differentiate between password and wallet users in MissingCSATModal.

Revision Contents
Changeset List

PathSize
web/
components/
59 lines

Diff 39806

View Options

web/components/log-out-if-missing-csat-handler.react.js

Loading...