Paths

Table of Contentst

Differential D12139

[native] Convert TabBar to Reanimated 2 syntax
ClosedPublic
Actions

Authored by ashoat on May 21 2024, 5:42 AM.

Details

Reviewers

inka

Commits

rCOMM2e351aa5e747: [native] Convert TabBar to Reanimated 2 syntax

Summary

This resolves ENG-8155.

Test Plan

I slowed down the animation by modifying tabBarAnimationDuration, and then recorded this video on my physical Android device:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 21 2024, 5:42 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 21 2024, 5:42 AM

ashoat edited the test plan for this revision. (Show Details)May 21 2024, 5:42 AM

Harbormaster returned this revision to the author for changes because remote builds failed.May 21 2024, 5:56 AM

Harbormaster failed remote builds in B29087: Diff 40450!

Rebase and remove DerivedValue type

Harbormaster completed remote builds in B29088: Diff 40452.May 21 2024, 6:24 AM

ashoat requested review of this revision.May 21 2024, 6:24 AM

inka accepted this revision.May 21 2024, 7:23 AM

This revision is now accepted and ready to land.May 21 2024, 7:23 AM

Closed by commit rCOMM2e351aa5e747: [native] Convert TabBar to Reanimated 2 syntax (authored by ashoat). · Explain WhyMay 21 2024, 8:58 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2e351aa5e747: [native] Convert TabBar to Reanimated 2 syntax.

Revision Contents
Changeset List

Path

Size

native/

flow-typed/

npm/

react-native-reanimated_v2.x.x.js

14 lines

navigation/

tab-bar.react.js

48 lines

Diff 40490

View Options

native/flow-typed/npm/react-native-reanimated_v2.x.x.js