Page MenuHomePhabricator

[native] Lift cancelButtonExpansion to ChatThreadList
ClosedPublic

Authored by ashoat on Fri, May 24, 7:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 16, 9:18 PM
Unknown Object (File)
Sat, Jun 15, 8:32 PM
Unknown Object (File)
Fri, Jun 14, 8:17 AM
Unknown Object (File)
Thu, Jun 13, 11:48 AM
Unknown Object (File)
Tue, Jun 11, 10:06 AM
Unknown Object (File)
Tue, Jun 11, 10:06 AM
Unknown Object (File)
Mon, Jun 10, 1:03 AM
Unknown Object (File)
Sun, Jun 9, 11:10 PM
Subscribers

Details

Summary

ChatThreadList can actually render ChatThreadListSearch in two different places: inside the FlatList, and right above it.

We render it inside the FlatList to start, but when the user focuses the search bar, we "dock" it so that the user can still see it while they scroll through the search results.

If we don't lift cancelButtonExpansion, the dismissal animation doesn't work, because it's initiated on a component that is then unmounted.

By lifting this SharedValue, we allow it to be shared between the two components that are mounted in different places.

Depends on D12166

Test Plan

Confirm that the dismiss animation actually works by overriding it to take 3 seconds

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable