Page MenuHomePhabricator

[keyserver] Allow staff to use reserved names for invite links
ClosedPublic

Authored by ashoat on May 29 2024, 1:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 12:34 PM
Unknown Object (File)
Sun, Nov 17, 8:03 AM
Unknown Object (File)
Tue, Nov 12, 11:54 AM
Unknown Object (File)
Tue, Nov 12, 11:29 AM
Unknown Object (File)
Tue, Nov 12, 6:21 AM
Unknown Object (File)
Tue, Nov 12, 4:52 AM
Unknown Object (File)
Mon, Nov 11, 11:18 PM
Unknown Object (File)
Sat, Nov 2, 6:48 AM
Subscribers
None

Details

Summary

This addresses the second part of ENG-8263: update the keyserver code to allow staff members to set invite links that are reserved.

Depends on D12242

Test Plan

Tested invite link flow end-to-end on web by creating an invite link named "music" as a keyserver admin, and then opening it in an Incognito tab as another user, and confirming I am able to join. Before modifying lib/facts/staff.json to include the local keyserver admin, it did not work. Afterwards it did

I was surprised that the staging blob service did not reject my invite link creation, given that I was using a reserved string. This calls into question whether any changes on the blob service are necessary. Will document this on ENG-8302.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage