Page MenuHomePhabricator

[native] Clean up Entry delete action
ClosedPublic

Authored by ashoat on May 31 2024, 6:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 5:49 AM
Unknown Object (File)
Sat, Nov 2, 5:48 AM
Unknown Object (File)
Sat, Nov 2, 5:46 AM
Unknown Object (File)
Sat, Nov 2, 5:26 AM
Unknown Object (File)
Thu, Oct 10, 10:12 PM
Unknown Object (File)
Thu, Oct 10, 10:12 PM
Unknown Object (File)
Thu, Oct 10, 10:12 PM
Unknown Object (File)
Thu, Oct 10, 10:12 PM
Subscribers
None

Details

Summary

Instead of dispatching an action with an empty payload when we want to skip it, we should skip dispatching an action altogether.

Depends on D12261

Test Plan
  1. Tested with the rest of the stack. Tested entry creation, deletion, deletion while editing, save after editing
  2. Flow and careful code inspection

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable