Page MenuHomePhabricator

[lib][native] update useDeleteDiscardedIdentityAccount to call deletePasswordUser when appropriate
ClosedPublic

Authored by varun on Jun 5 2024, 9:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 6:57 AM
Unknown Object (File)
Tue, Nov 12, 4:29 PM
Unknown Object (File)
Tue, Nov 12, 3:56 PM
Unknown Object (File)
Tue, Nov 12, 3:07 PM
Unknown Object (File)
Tue, Nov 12, 2:38 PM
Unknown Object (File)
Thu, Nov 7, 7:14 PM
Unknown Object (File)
Wed, Nov 6, 1:47 AM
Unknown Object (File)
Mon, Nov 4, 1:37 AM
Subscribers
None

Details

Summary

in a later diff, we'll be restricting deleteWalletUser to only be called by wallet accounts. before then, we need username accounts to call deletePasswordUser instead.

Test Plan

tried registering a wallet and password user with my authoritative keyserver offline. confirmed in CloudWatch logs that both accounts were successfully registered and then subsequently deleted when keyserver auth failed. checked that the correct RPC was called each time

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/actions/user-actions.js
385 ↗(On Diff #41001)

deleteUserPromise might be a better name, actually

varun requested review of this revision.Jun 5 2024, 9:21 PM
ashoat added inline comments.
lib/actions/user-actions.js
385 ↗(On Diff #41001)

Agree

This revision is now accepted and ready to land.Jun 6 2024, 9:53 AM