Page MenuHomePhabricator
Differential D12353

[native][lib] update useDeleteDiscardedIdentityAccount to throw
ClosedPublic
Actions

Authored by varun on Jun 7 2024, 9:11 AM.
Tags
None
Referenced Files
F3487274: D12353.id41119.diff
Wed, Dec 18, 7:30 AM
F3487273: D12353.id41111.diff
Wed, Dec 18, 7:30 AM
F3487264: D12353.id.diff
Wed, Dec 18, 7:30 AM
F3487260: D12353.diff
Wed, Dec 18, 7:30 AM
Unknown Object (File)
Fri, Dec 13, 9:55 PM
Unknown Object (File)
Mon, Dec 2, 1:42 AM
Unknown Object (File)
Nov 13 2024, 7:57 PM
Unknown Object (File)
Nov 13 2024, 7:57 PM
View All 60 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM008d75b22080: [native][lib] update useDeleteDiscardedIdentityAccount to throw
Summary

we need this hook to throw so that we can catch exceptions in useRegistrationServerCall and alert the user if their account was successfully created but login failed.

Depends on D12335

Test Plan

applied this patch: https://gist.github.com/vdhanan/0a8bd816ab34cd2df3fdb46a73087f0b

then confirmed that DELETE_ACCOUNT_SUCCESS was dispatched and the Alert was displayed (see screenshot)

Simulator Screenshot - iPhone 15 Pro Max - 2024-06-07 at 12.06.10.png (2×1 px, 456 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Jun 7 2024, 9:11 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 7 2024, 9:11 AM
varun published this revision for review.Jun 7 2024, 9:12 AM
varun edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B29535: Diff 41111.Jun 7 2024, 9:31 AM
ashoat accepted this revision.Jun 7 2024, 10:57 AM
ashoat added inline comments.
lib/actions/user-actions.js
494 ↗(On Diff #41111)

Unrelated, but I wonder if we should use the standard timeout instead of this shorter one. 500ms is rather short

This revision is now accepted and ready to land.Jun 7 2024, 10:57 AM
varun added inline comments.Jun 7 2024, 11:45 AM
lib/actions/user-actions.js
494 ↗(On Diff #41111)

bumped to 5000

Closed by commit rCOMM008d75b22080: [native][lib] update useDeleteDiscardedIdentityAccount to throw (authored by varun). · Explain WhyJun 7 2024, 11:47 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM008d75b22080: [native][lib] update useDeleteDiscardedIdentityAccount to throw.
varun attached a referenced file: F1968729: Simulator Screenshot - iPhone 15 Pro Max - 2024-06-07 at 12.06.10.png. (Show Details)Jun 7 2024, 8:51 PM

Revision Contents
Changeset List

PathSize
lib/
actions/
34 lines
shared/
3 lines
native/
account/
registration/
76 lines

Diff 41119

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/shared/timeouts.js

Loading...
View Options

native/account/registration/registration-server-call.js

Loading...