Page MenuHomePhabricator

[keyserver] Make sure to reset session when lastUpdate is 0
ClosedPublic

Authored by ashoat on Mon, Jun 10, 9:18 PM.
Tags
None
Referenced Files
F2026757: D12389.id41197.diff
Mon, Jun 17, 5:52 PM
F2026621: D12389.id41205.diff
Mon, Jun 17, 5:37 PM
Unknown Object (File)
Sat, Jun 15, 5:20 PM
Unknown Object (File)
Tue, Jun 11, 9:05 AM
Unknown Object (File)
Tue, Jun 11, 8:48 AM
Subscribers

Details

Summary

See the code comment. This situation can happen after registration, where it would be harmless to do a session reset. And it can happen if policies are not acknowledged at the time of a login, in which case we really to reset it after the policies are acknowledged.

Depends on D12388

Test Plan

Prior to this, my test plan in D12386 would repopulate some data, but not all data. The issue is that we were treating it as an INCREMENTAL rather than FULL, but INCREMENTAL was not possible from time 0 because some of the updates since that point had been deleted.

In additional to that, I did some work to verify the safety of this change:

  1. I tested registration via the new registration flow, and confirmed that nothing weird happened (this is the other case where serverTime is set to 0)
  2. I looked through the login/registration code on keyserver and on the client to confirm that there were only two cases where serverTime was set to 0

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable