Page MenuHomePhabricator
Differential D12418

[lib] Add validator support for 'Unauthenticated' Tunnelbroker message
ClosedPublic
Actions

Authored by bartek on Thu, Jun 13, 2:44 AM.
Tags
None
Referenced Files
F2153947: D12418.id.diff
Sun, Jun 30, 6:24 PM
F2153603: D12418.id41318.diff
Sun, Jun 30, 5:31 PM
F2153487: D12418.id41273.diff
Sun, Jun 30, 5:16 PM
Unknown Object (File)
Fri, Jun 28, 11:39 PM
Unknown Object (File)
Fri, Jun 28, 8:00 PM
Unknown Object (File)
Fri, Jun 28, 5:25 PM
Unknown Object (File)
Fri, Jun 28, 3:43 PM
Unknown Object (File)
Thu, Jun 27, 5:33 PM
View All 20 Files
Subscribers
tomek

Details

Reviewers
kamil
ashoat
Commits
rCOMMcf79e85283ea: [lib] Add validator support for 'Unauthenticated' Tunnelbroker message
Summary

Addresses ENG-8394.
The Unauthenticated enum variant was missing in client-side validator.

Added a comment to keep that in sync.

Test Plan
  1. Hardcoded setUnauthorizedDeviceID(not-null-value) to keep Tunnelbroker connection anonymous.
  2. Called tunnelbrokerContext.sendMessage()
  3. Verified that invalid TunnelbrokerMessage is no longer occuring

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Thu, Jun 13, 2:44 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptThu, Jun 13, 2:44 AM
Harbormaster completed remote builds in B29650: Diff 41273.Thu, Jun 13, 3:01 AM
bartek published this revision for review.Thu, Jun 13, 10:02 PM
kamil accepted this revision.Fri, Jun 14, 1:44 AM
kamil added inline comments.
shared/tunnelbroker_messages/src/messages/message_to_device_request_status.rs
12–13 ↗(On Diff #41273)

We already have a general comment one level higher in mod.rs, bur probably adding this here wouldn't hurt

This revision is now accepted and ready to land.Fri, Jun 14, 1:44 AM
Closed by commit rCOMMcf79e85283ea: [lib] Add validator support for 'Unauthenticated' Tunnelbroker message (authored by bartek). · Explain WhyFri, Jun 14, 2:43 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMcf79e85283ea: [lib] Add validator support for 'Unauthenticated' Tunnelbroker message.

Revision Contents
Changeset List

PathSize
lib/
types/
tunnelbroker/
4 lines
shared/
tunnelbroker_messages/
src/
messages/
4 lines

Diff 41318

View Options

lib/types/tunnelbroker/message-to-device-request-status-types.js

Loading...
View Options

shared/tunnelbroker_messages/src/messages/message_to_device_request_status.rs

Loading...