[web] fix uncaught exception bug
ClosedPublic
Actions

Authored by varun on Jun 18 2024, 8:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 8:05 PM

	Unknown Object (File)
	Sat, Dec 7, 7:22 PM

	Unknown Object (File)
	Nov 3 2024, 5:38 AM

	Unknown Object (File)
	Oct 12 2024, 2:55 PM

	Unknown Object (File)
	Oct 12 2024, 2:55 PM

	Unknown Object (File)
	Oct 12 2024, 2:55 PM

	Unknown Object (File)
	Oct 12 2024, 2:55 PM

	Unknown Object (File)
	Sep 20 2024, 1:27 AM

View All 40 Files

Subscribers

tomek

Details

Reviewers

ashoat
inka

Commits

rCOMMfd8be14a14af: [web] fix uncaught exception bug

Summary

we don't need to re-throw here. i think this was introduced in D11765, when we introduced new login hooks.

Test Plan

no longer getting an uncaught exception error when i enter an incorrect password

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jun 18 2024, 8:19 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 18 2024, 8:19 PM

Harbormaster completed remote builds in B29766: Diff 41476.Jun 18 2024, 8:36 PM

varun requested review of this revision.Jun 18 2024, 8:36 PM

ashoat accepted this revision.Jun 19 2024, 5:25 AM

This revision is now accepted and ready to land.Jun 19 2024, 5:25 AM

Closed by commit rCOMMfd8be14a14af: [web] fix uncaught exception bug (authored by varun). · Explain WhyJun 19 2024, 6:39 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMfd8be14a14af: [web] fix uncaught exception bug.

Revision Contents
Changeset List

Path

Size

web/

account/

traditional-login-form.react.js

1 line

Diff 41489

View Options

web/account/traditional-login-form.react.js

[web] fix uncaught exception bugClosedPublicActions