[identity][proto] addWallet RPC
Needs RevisionPublic
Actions

Authored by varun on Jun 25 2024, 2:11 PM.

Details

Reviewers

bartek
ashoat

Summary

https://linear.app/comm/issue/ENG-8306/addwalletstart-rpc

this diff introduces two things:

new RPC
new traits to avoid code duplication

Test Plan

wallet login works. if nonce is expired, i get back the correct tonic status message

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jun 25 2024, 2:11 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 25 2024, 2:11 PM

varun edited the summary of this revision. (Show Details)Jun 25 2024, 2:12 PM

Harbormaster completed remote builds in B29925: Diff 41699.Jun 25 2024, 2:28 PM

varun requested review of this revision.Jun 25 2024, 2:28 PM

Rust LGTM, nice idea with these traits!

services/identity/src/grpc_services/shared.rs
69
70
services/identity/src/nonce.rs
46	Just curious, what requires `Sync`?

Passing back with a question: I assume your plan is to land this before the rest of the work. Is that actually safe? Are we okay to launch this publicly accessible endpoint for adding a wallet when the rest of the work is not yet in a landable state?

This revision now requires changes to proceed.Jul 1 2024, 11:31 AM