Page MenuHomePhabricator
Differential D12575

[identity][proto] addWallet RPC
Needs ReviewPublic
Actions

Authored by varun on Tue, Jun 25, 2:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 27, 11:06 AM
Unknown Object (File)
Tue, Jun 25, 9:03 PM
Unknown Object (File)
Tue, Jun 25, 6:59 PM
Subscribers
tomek

Details

Reviewers
bartek
ashoat
Summary

https://linear.app/comm/issue/ENG-8306/addwalletstart-rpc

this diff introduces two things:

  1. new RPC
  2. new traits to avoid code duplication
Test Plan

wallet login works. if nonce is expired, i get back the correct tonic status message

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Tue, Jun 25, 2:11 PM
Herald added a subscriber: tomek. · View Herald TranscriptTue, Jun 25, 2:11 PM
varun edited the summary of this revision. (Show Details)Tue, Jun 25, 2:12 PM
Harbormaster completed remote builds in B29925: Diff 41699.Tue, Jun 25, 2:28 PM
varun requested review of this revision.Tue, Jun 25, 2:28 PM
bartek accepted this revision.Wed, Jun 26, 12:44 AM

Rust LGTM, nice idea with these traits!

services/identity/src/grpc_services/shared.rs
69
70
services/identity/src/nonce.rs
46

Just curious, what requires Sync?

Revision Contents
Changeset List

PathSize
services/
identity/
src/
35 lines
grpc_services/
11 lines
20 lines
49 lines
shared/
protos/
9 lines
web/
protobufs/
13 lines
20 lines

Diff 41699

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...
View Options

services/identity/src/grpc_services/shared.rs

Loading...
View Options

services/identity/src/nonce.rs

Loading...
View Options

shared/protos/identity_auth.proto

Loading...
View Options

web/protobufs/identity-auth-client.cjs

Loading...
View Options

web/protobufs/identity-auth-client.cjs.flow

Loading...
View Options

web/protobufs/identity-auth-structs.cjs

Loading...
View Options

web/protobufs/identity-auth-structs.cjs.flow

Loading...