Page MenuHomePhabricator

[web] fix leave channel modal for long thread names
ClosedPublic

Authored by ginsu on Jun 27 2024, 12:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 19, 8:45 PM
Unknown Object (File)
Fri, Oct 11, 1:24 AM
Unknown Object (File)
Fri, Oct 11, 1:24 AM
Unknown Object (File)
Fri, Oct 11, 1:24 AM
Unknown Object (File)
Fri, Oct 11, 1:24 AM
Unknown Object (File)
Fri, Oct 11, 1:23 AM
Unknown Object (File)
Oct 5 2024, 2:22 AM
Unknown Object (File)
Oct 4 2024, 11:55 PM
Subscribers

Details

Summary

This fixes a bug where the modal would gorw really wide if the thread name has a really long name. This diff fixes this bug

Linear task: https://linear.app/comm/issue/ENG-8438/leave-channel-modal-on-web-grows-when-a-thread-has-a-really-long-name

Test Plan

Please see the screenshots

Before:

Screenshot 2024-06-27 at 3.42.59 AM.png (1×3 px, 619 KB)

After:

Screenshot 2024-06-27 at 3.43.06 AM.png (2×3 px, 862 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: inka.
ginsu requested review of this revision.Jun 27 2024, 1:01 AM

Don't love hardcoding pixel values like this. Should it be a CSS variable?

This revision is now accepted and ready to land.Jul 1 2024, 11:50 AM

address comments + rebase before landing