Page MenuHomePhabricator

[lib][native] Introduce isLoggedInToIdentityAndAuthoritativeKeyserver
ClosedPublic

Authored by ashoat on Jul 8 2024, 10:25 AM.
Tags
None
Referenced Files
F3353267: D12697.diff
Sat, Nov 23, 9:08 AM
Unknown Object (File)
Thu, Nov 21, 2:28 AM
Unknown Object (File)
Mon, Nov 11, 2:08 AM
Unknown Object (File)
Mon, Nov 11, 1:52 AM
Unknown Object (File)
Sun, Nov 10, 7:39 PM
Unknown Object (File)
Sun, Nov 10, 3:02 PM
Unknown Object (File)
Oct 23 2024, 7:07 PM
Unknown Object (File)
Oct 11 2024, 2:58 AM
Subscribers
None

Details

Summary

Follow-up to the previous diff that combines isLoggedIn. This lets us factor out some logic in the codebase.

Depends on D12696

Test Plan

This should be a simple no-op refactor, so my testing was limited:

  1. Flow
  2. Careful inspection of the code
  3. The changes to NavigationHandler were tested as part of the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/components/auto-join-community-handler.react.js
36 ↗(On Diff #42122)

There is a minor change here and in ConnectFarcasterAlertHandler below. Previously currentUserID could be set for an anonymous cookie, but now that's not possible. I think this a good change – neither of these handlers should be called if the cookie is anonymous

This revision is now accepted and ready to land.Jul 9 2024, 5:00 AM