Page MenuHomePhabricator
Differential D12726

[web] Allow creating subchannels with no other users
ClosedPublic
Actions

Authored by inka on Jul 11 2024, 5:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 8:12 AM
Unknown Object (File)
Wed, Mar 12, 6:23 AM
Unknown Object (File)
Tue, Mar 11, 2:07 PM
Unknown Object (File)
Feb 21 2025, 2:54 AM
Unknown Object (File)
Feb 21 2025, 2:54 AM
Unknown Object (File)
Feb 21 2025, 2:53 AM
Unknown Object (File)
Feb 21 2025, 2:52 AM
Unknown Object (File)
Jan 29 2025, 11:18 PM
View All 85 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMbc6eb2904fbe: [web] Allow creating subchannels with no other users
Summary

issue: [[https://linear.app/comm/issue/ENG-8811/[web]-dont-require-members-when-creating-subchannel | ENG-8811]]
We want to match native and allow creating subchannels with no other users

Test Plan

Tested that it is possible to create a subchannel with no other users
Tested that the created robotext makes sense:
"you created this channel as a child of delete thread with the name "m h""

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
create/
3 lines

Diff 42254

View Options

web/modals/threads/create/compose-subchannel-modal.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import blobService from '../facts/blob-service.js';
import { import {
type AuthMetadata, type AuthMetadata,
IdentityClientContext, IdentityClientContext,
} from '../shared/identity-client-context.js'; } from '../shared/identity-client-context.js';
import type { import type {
BlobHashAndHolder, BlobHashAndHolder,
BlobOperation, BlobOperation,
} from '../types/holder-types.js'; } from '../types/holder-types.js';
import { toBase64URL } from '../utils/base64.js'; import { toBase64URL } from '../utils/base64.js';
import { import {
makeBlobServiceEndpointURL,
generateBlobHolder, generateBlobHolder,
assignMultipleHolders,
removeMultipleHolders,
} from '../utils/blob-service.js'; } from '../utils/blob-service.js';
import { useDispatchActionPromise } from '../utils/redux-promise-utils.js'; import { useDispatchActionPromise } from '../utils/redux-promise-utils.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
import { createDefaultHTTPRequestHeaders } from '../utils/services-utils.js'; import { createDefaultHTTPRequestHeaders } from '../utils/services-utils.js';
type MultipleBlobHolders = $ReadOnlyArray<BlobHashAndHolder>; type MultipleBlobHolders = $ReadOnlyArray<BlobHashAndHolder>;
export const storeEstablishedHolderActionType = 'STORE_ESTABLISHED_HOLDER'; export const storeEstablishedHolderActionType = 'STORE_ESTABLISHED_HOLDER';
Show All 18 Linesexport type ProcessHoldersFinishedPayload = {
+notRemoved: MultipleBlobHolders, +notRemoved: MultipleBlobHolders,
}; };
type BlobServiceActionsResult = { type BlobServiceActionsResult = {
+succeeded: MultipleBlobHolders, +succeeded: MultipleBlobHolders,
+failed: MultipleBlobHolders, +failed: MultipleBlobHolders,
}; };
// This function can be simplified when batch holders operations
// are implemented on Blob Service
async function performBlobServiceHolderActions( async function performBlobServiceHolderActions(
action: 'establish' | 'remove', action: 'establish' | 'remove',
inputs: MultipleBlobHolders, inputs: MultipleBlobHolders,
authMetadata: AuthMetadata, authMetadata: AuthMetadata,
): Promise<BlobServiceActionsResult> { ): Promise<BlobServiceActionsResult> {
if (inputs.length === 0) { if (inputs.length === 0) {
return { succeeded: [], failed: [] }; return { succeeded: [], failed: [] };
} }
const endpoint =
action === 'establish'
? blobService.httpEndpoints.ASSIGN_HOLDER
: blobService.httpEndpoints.DELETE_BLOB;
const endpointURL = makeBlobServiceEndpointURL(endpoint);
const defaultHeaders = createDefaultHTTPRequestHeaders(authMetadata); const defaultHeaders = createDefaultHTTPRequestHeaders(authMetadata);
const blobServiceCall =
action === 'establish' ? assignMultipleHolders : removeMultipleHolders;
const promises = inputs.map(async input => { const requestInputs = inputs.map(({ blobHash, ...rest }) => ({
const blobHash = toBase64URL(input.blobHash); ...rest,
try { blobHash: toBase64URL(blobHash),
const response = await fetch(endpointURL, { }));
method: endpoint.method, const response = await blobServiceCall(requestInputs, defaultHeaders);
body: JSON.stringify({ if (response.result === 'success') {
holder: input.holder, return { succeeded: inputs, failed: [] };
blob_hash: blobHash, }
}), if (response.result === 'error') {
headers: { return { succeeded: [], failed: inputs };
...defaultHeaders, }
'content-type': 'application/json',
}, const failedRequestsSet = new Set(
}); response.failedRequests.map(({ blobHash, holder }) =>
const holderAlreadyEstablishedResponse = JSON.stringify({ blobHash, holder }),
action === 'establish' && response.status === 409; ),
if (response.ok || holderAlreadyEstablishedResponse) { );
return { ...input, success: true };
}
return { ...input, success: false };
} catch (e) {
return { ...input, success: false };
}
});
const results = await Promise.all(promises);
const succeeded = [], const succeeded = [],
failed = []; failed = [];
for (const { success, ...holderEntry } of results) { for (const item of inputs) {
if (success) { const stringifiedItem = JSON.stringify({
succeeded.push(holderEntry); blobHash: toBase64URL(item.blobHash),
holder: item.holder,
});
if (failedRequestsSet.has(stringifiedItem)) {
failed.push(item);
} else { } else {
failed.push(holderEntry); succeeded.push(item);
} }
} }
return { return { succeeded, failed };
succeeded,
failed,
};
} }
async function processHoldersAction( async function processHoldersAction(
input: ProcessHoldersStartedPayload, input: ProcessHoldersStartedPayload,
authMetadata: AuthMetadata, authMetadata: AuthMetadata,
): Promise<ProcessHoldersFinishedPayload> { ): Promise<ProcessHoldersFinishedPayload> {
const [ const [
{ succeeded: added, failed: notAdded }, { succeeded: added, failed: notAdded },
▲ Show 20 Lines • Show All 114 Lines • Show Last 20 Lines