Page MenuHomePhabricator
Differential D12810

[keyserver] run webapp, landing, and keyserver conditionally
ClosedPublic
Actions

Authored by will on Jul 19 2024, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 11:37 AM
Unknown Object (File)
Oct 23 2024, 7:23 PM
Unknown Object (File)
Oct 23 2024, 7:23 PM
Unknown Object (File)
Oct 23 2024, 7:23 PM
Unknown Object (File)
Oct 23 2024, 7:23 PM
Unknown Object (File)
Oct 23 2024, 7:21 PM
Unknown Object (File)
Oct 23 2024, 1:49 PM
Unknown Object (File)
Oct 23 2024, 1:43 PM
View All 74 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM083b66c6c741: [keyserver] run webapp, landing, and keyserver conditionally
Summary

We plan to decouple running the keyserver, webapp, and landing for the purposes of running them on AWS

This adds a configuration option RunServerConfig which can be used to specify which of the three will be run

Depends on D12808

Test Plan

flow check. Will test more thoroughly by running them on aws in isolated containers and connect them

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Jul 19 2024, 3:07 PM
Herald added a subscriber: tomek. · View Herald TranscriptJul 19 2024, 3:07 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2024, 3:24 PM
Harbormaster failed remote builds in B30524: Diff 42559!
will updated this revision to Diff 42560.Jul 19 2024, 4:01 PM

missing await

Harbormaster completed remote builds in B30525: Diff 42560.Jul 19 2024, 4:17 PM
will requested review of this revision.Jul 19 2024, 4:17 PM
ashoat accepted this revision.Jul 19 2024, 8:32 PM
ashoat added inline comments.
keyserver/src/utils/server-utils.js
1 ↗(On Diff #42560)

Add newline below this before landing please

This revision is now accepted and ready to land.Jul 19 2024, 8:32 PM
will added a child revision: D12813: [terraform] add webapp, landing domains and rename keyserver domain variables.Jul 19 2024, 8:32 PM
will updated this revision to Diff 42571.Jul 19 2024, 8:48 PM

newline

This revision was landed with ongoing or failed builds.Jul 19 2024, 8:49 PM
Closed by commit rCOMM083b66c6c741: [keyserver] run webapp, landing, and keyserver conditionally (authored by will). · Explain Why
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM083b66c6c741: [keyserver] run webapp, landing, and keyserver conditionally.
Harbormaster completed remote builds in B30533: Diff 42571.Jul 19 2024, 9:04 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
9 lines
utils/
25 lines

Diff 42571

View Options

keyserver/src/keyserver.js

Loading...
View Options

keyserver/src/utils/server-utils.js

Loading...