Page MenuHomePhabricator

[native] Update to react-native-ffmpeg@0.5.2
AbandonedPublic

Authored by ashoat on Aug 5 2024, 4:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 6:15 PM
Unknown Object (File)
Sun, Nov 10, 12:34 PM
Unknown Object (File)
Sun, Oct 27, 9:08 AM
Unknown Object (File)
Oct 19 2024, 8:24 AM
Unknown Object (File)
Oct 18 2024, 9:44 PM
Unknown Object (File)
Oct 18 2024, 9:44 PM
Unknown Object (File)
Oct 6 2024, 9:03 PM
Unknown Object (File)
Oct 6 2024, 6:00 PM
Subscribers

Details

Reviewers
will
Summary

This addresses ENG-8959 by upgrading the transitive dependency mobile-ffmpeg-min-gpl. Some additional context in ENG-4177.

react-native-ffmpeg is deprecated, and we should migrate to ffmpeg-kit. I don't have time to do that right now, unfortunately.

Depends on D12992

Test Plan
  1. It built on my local environment
  2. Make sure CI passes

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/android
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2024, 4:20 PM
Harbormaster failed remote builds in B30945: Diff 43160!

Fix iOS by bumping expo-image one patch version to 1.2.3

ashoat published this revision for review.Aug 5 2024, 6:01 PM
This revision is now accepted and ready to land.Aug 5 2024, 6:02 PM

Unfortunately this update seems to break RNFFprobe.getMediaInformation, at least on iOS. More details here and here, but suffice it to say that if we ever need to revisit this, we'll probably need to proceed with the full migration to ffmpeg-kit (tracked here).