Page MenuHomePhabricator

[native] make SecondaryDeviceQRCodeScanner dismissible
ClosedPublic

Authored by varun on Aug 9 2024, 12:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 14, 7:41 PM
Unknown Object (File)
Mon, Oct 14, 7:41 PM
Unknown Object (File)
Mon, Oct 14, 7:41 PM
Unknown Object (File)
Mon, Oct 14, 7:40 PM
Unknown Object (File)
Sep 20 2024, 4:20 AM
Unknown Object (File)
Sep 15 2024, 3:52 PM
Unknown Object (File)
Sep 8 2024, 1:55 PM
Unknown Object (File)
Sep 8 2024, 1:55 PM
Subscribers

Details

Summary

If you reject the Alert that pops up when you scan a QR code, the same alert will pop up if your phone camera is still pointed at the QR code. Instead, we should just go back when the cancel button is pressed.

https://linear.app/comm/issue/ENG-8935/cant-dismiss-secondarydeviceqrcodescanner

Test Plan

confirmed that if I press cancel on the Alert, I'm navigated back to the linked devices screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable