[native] make SecondaryDeviceQRCodeScanner dismissible
ClosedPublic
Actions

Authored by varun on Aug 9 2024, 12:14 PM.

Details

Reviewers

Commits

rCOMM06326715f289: [native] make SecondaryDeviceQRCodeScanner dismissible

Summary

If you reject the Alert that pops up when you scan a QR code, the same alert will pop up if your phone camera is still pointed at the QR code. Instead, we should just go back when the cancel button is pressed.

https://linear.app/comm/issue/ENG-8935/cant-dismiss-secondarydeviceqrcodescanner

Test Plan

confirmed that if I press cancel on the Alert, I'm navigated back to the linked devices screen

Diff Detail

Repository

rCOMM Comm

Branch

hackathon (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 9 2024, 12:14 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 9 2024, 12:14 PM

Harbormaster completed remote builds in B31024: Diff 43276.Aug 9 2024, 12:36 PM

varun requested review of this revision.Aug 9 2024, 12:36 PM

ashoat accepted this revision.Aug 10 2024, 2:03 PM

This revision is now accepted and ready to land.Aug 10 2024, 2:03 PM

Closed by commit rCOMM06326715f289: [native] make SecondaryDeviceQRCodeScanner dismissible (authored by varun). · Explain WhyAug 19 2024, 7:17 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM06326715f289: [native] make SecondaryDeviceQRCodeScanner dismissible.

Revision Contents
Changeset List

Path

Size

native/

profile/

secondary-device-qr-code-scanner.react.js

6 lines

Diff 43276

View Options

native/profile/secondary-device-qr-code-scanner.react.js

[native] make SecondaryDeviceQRCodeScanner dismissibleClosedPublicActions