Page MenuHomePhabricator
Differential D13036

[native] make SecondaryDeviceQRCodeScanner dismissible
ClosedPublic
Actions

Authored by varun on Aug 9 2024, 12:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 7, 6:32 AM
Unknown Object (File)
Mon, Apr 7, 2:24 AM
Unknown Object (File)
Mon, Apr 7, 12:56 AM
Unknown Object (File)
Sun, Apr 6, 8:31 AM
Unknown Object (File)
Sun, Apr 6, 6:09 AM
Unknown Object (File)
Wed, Mar 26, 8:36 AM
Unknown Object (File)
Mar 4 2025, 9:39 PM
Unknown Object (File)
Feb 28 2025, 11:55 AM
View All 68 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM06326715f289: [native] make SecondaryDeviceQRCodeScanner dismissible
Summary

If you reject the Alert that pops up when you scan a QR code, the same alert will pop up if your phone camera is still pointed at the QR code. Instead, we should just go back when the cancel button is pressed.

https://linear.app/comm/issue/ENG-8935/cant-dismiss-secondarydeviceqrcodescanner

Test Plan

confirmed that if I press cancel on the Alert, I'm navigated back to the linked devices screen

Diff Detail

Repository
rCOMM Comm
Branch
hackathon (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
profile/
6 lines

Diff 43276

View Options

native/profile/secondary-device-qr-code-scanner.react.js

use anyhow::Result; use anyhow::Result;
use comm_lib::{auth::AuthService, blob::client::BlobServiceClient}; use comm_lib::{auth::AuthService, blob::client::BlobServiceClient};
use tracing::Level; use tracing::Level;
use tracing_subscriber::EnvFilter; use tracing_subscriber::EnvFilter;
pub mod config; pub mod config;
pub mod constants; pub mod constants;
pub mod database; pub mod database;
pub mod error; pub mod error;
pub mod http; pub mod http;
pub mod identity;
// re-export this to be available as crate::CONFIG // re-export this to be available as crate::CONFIG
pub use config::CONFIG; pub use config::CONFIG;
fn configure_logging() -> Result<()> { fn configure_logging() -> Result<()> {
let filter = EnvFilter::builder() let filter = EnvFilter::builder()
.with_default_directive(Level::INFO.into()) .with_default_directive(Level::INFO.into())
.with_env_var(constants::LOG_LEVEL_ENV_VAR) .with_env_var(constants::LOG_LEVEL_ENV_VAR)
Show All 21 Lines