Page MenuHomePhabricator
Differential D13036

[native] make SecondaryDeviceQRCodeScanner dismissible
ClosedPublic
Actions

Authored by varun on Aug 9 2024, 12:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 5:13 AM
Unknown Object (File)
Wed, Nov 20, 5:13 AM
Unknown Object (File)
Wed, Nov 20, 5:13 AM
Unknown Object (File)
Wed, Nov 20, 5:09 AM
Unknown Object (File)
Tue, Nov 19, 8:14 PM
Unknown Object (File)
Wed, Nov 13, 9:07 PM
Unknown Object (File)
Wed, Nov 13, 8:55 PM
Unknown Object (File)
Oct 14 2024, 7:41 PM
View All 43 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM06326715f289: [native] make SecondaryDeviceQRCodeScanner dismissible
Summary

If you reject the Alert that pops up when you scan a QR code, the same alert will pop up if your phone camera is still pointed at the QR code. Instead, we should just go back when the cancel button is pressed.

https://linear.app/comm/issue/ENG-8935/cant-dismiss-secondarydeviceqrcodescanner

Test Plan

confirmed that if I press cancel on the Alert, I'm navigated back to the linked devices screen

Diff Detail

Repository
rCOMM Comm
Branch
hackathon (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
profile/
6 lines

Diff 43276

View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...